Repository navigation
fix(undo-close): a restored agent keeps its derived TLDR identity - #1356
Merged
Juliusolsson05 merged 11 commits intoSep 27, 2026
Merged
Juliusolsson05 merged 11 commits into
Juliusolsson05 merged 11 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Undo Close passed only the explicit tldrIdentity, so an agent whose identity was derived (reporting domains on, no explicit field) came back with a fresh one. It now uses tldrIdentityForSession, the rule Reload Agents uses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Juliusolsson05
added
type:bug
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…bers Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d-identity # Conflicts: # src/renderer/src/workspace/hook/actions/undoClose.ts
…d-identity # Conflicts: # src/renderer/src/workspace/hook/actions/undoClose.ts
Owner
Author
|
Review disposition. Round 1: a MERGE-READY; b and c FIX-BEFORE-MERGE. Verification: b MERGE-READY (round 2). c FIX-BEFORE-MERGE in round 2 (a base conflict, plus a project test that needed two derived members), then MERGE-READY in round 3 at Fixed
Out of scope (the PR and #1347 are narrowed to the TLDR/Goal identity)
Info (a2): the real-data count shows that the derived state is a transient window, not the steady state. No change needed. 🤖 Generated with Claude Code |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Juliusolsson05
changed the base branch from
main
to
integration/batch-2026-09-27-p
September 27, 2026 20:35
Juliusolsson05
merged commit Sep 27, 2026
89259ab
into
integration/batch-2026-09-27-p
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1347.
Plan:
docs/plans/2026-09-26-undo-close-derived-identity.md(first commit).Problem
Undo Close respawned a closed agent with
tldrIdentity: meta.tldrIdentity, the explicit field only. An agent whose identity is DERIVED has no explicit field: its reporting domains are on, but main created it, or its metadata arrived after it acquired TLDR or Goal. Its identity is its session id (tldrIdentityForSession). Undo Close gave itundefined, sospawnminted a fresh UUID. The restored agent then had a new TLDR/Goal identity, so its TLDR and Goal records were no longer reachable from the restored pane. Reload Agents already used the derived rule. Found by review a of #1342.What merges
tldrIdentityForSession(closedSessionId, meta), the rule Reload Agents uses.respawnnow takes the closed id; both callers (a single pane, a project member) have it.Scope
This PR fixes the TLDR/Goal identity (#1347, narrowed after review). Agent Analytics continuity across the new session id is #1342, which can land before or after this one.
Tests
undoCloseFailure.renderer.test.tsx:tldrIdentity, and an explicit one passes through unchanged; red on main (undefined);ff32bce5(main, including fix(goal-loop): Undo Close hands the restored pane its goal loop #1331, merged),npx tsc -bis clean and the renderer actions suites pass (252 tests).🤖 Generated with Claude Code